centowen / salsa

MIT License
2 stars 1 forks source link

Extract TelescopeController from SalsaTelescope #71

Closed symmsaur closed 1 year ago

symmsaur commented 1 year ago

We want to achieve two things:

To do this we take out the parts relating to the telescope controller from SalsaTelescope. The SalsaTelescope remains as a facade but can in the future be broken up further.

By using a long lived task to do all communication to with one telescope controller we prepare for using less large locks in the future. Updating the telescope continuously (e.g while tracking) is moved into this task. This allows other parts of the system to send commands and observe the effects on the telescope without having to continuously drive it.

symmsaur commented 1 year ago

@centowen I think this looks quite promising, what do you think? If good I can get going on updating the tests and actually testing that it works for real.

centowen commented 1 year ago

Sorry for slow reply. Got a bit stuck in Elden Ring. :) I think this looks like a great improvement!

symmsaur commented 1 year ago

Now works with the fake telescope controller. Needs test with real telescope controller, then can be merged.