search

centralnicgroup-opensource / rtldev-middleware-whmcs

CentralNic's WHMCS Software Bundle
https://centralnicreseller.com
Other
40 stars 15 forks source link

HK domains transfer problem #198

Closed ikitaez closed 3 years ago

ikitaez commented 3 years ago

Transfer of HK domains is not working, always got error "Invalid Parameter: X-HK-ACCEPT-INDIVIDUAL-REGISTRATION-TAC" when accepting order, and it doesn't matter if the field Terms for Individuals is checked or not, always is same error. As i readed at your wiki page for HK domains, additional fields is not needed when transferring domains, but as i see in WHMCS log all of them is posted. Maybe problem in that? Unfortunately i cant fix it myself as your code is encrypted.

KaiSchwarz-cnic commented 3 years ago

Hi @ikitaez,

Thanks for reporting, I will immediately start working on a patch tomorrow.

I'll keep you posted.

Kai

KaiSchwarz-cnic commented 3 years ago

v6.1.3 fixes this issue.

The origin of this issue has to be seen in WHMCS Core. In Shopping Cart they request the additional fields for Registration in general. We just completely ignored them in the past therefore, but this also didn't work for every TLD as some require additional fields for transfer (a subset of the ones related to the registration process). Our v6 release branch changed that, but we missed to cleanup additional fields that are not required. I used a .fr domain to play with transfers and to work on a patch for this - .fr is comparable to .hk in that point as both do not require additional domain fields for transfers. My patch worked fine and cleaned these additional fields successfully up.

Just in case there are in future again issues with additional fields - I expect this then just to be an internal configuration issue that we can fix in ease. The mechanism (except of the WHMCS Core behavior) looks perfect imho.

Again many thanks @ikitaez for reporting this, very appreciated.

ikitaez commented 3 years ago

Hello. Thanks for fast reply, unfortunately now it says Missing required attribute; X-HK-REGISTRANT-DOCUMENT-TYPE)] Looks like some fields is required..

KaiSchwarz-cnic commented 3 years ago

Ok, thanks for forwarding. I'll check that immediately. That's even not documented in our wiki: https://wiki.hexonet.net/wiki/HK and the reason why flags are completely cleaned up in our integration. And also not listed in our API Docs: https://github.com/hexonet/hexonet-api-documentation/blob/master/API/DOMAIN/TRANSFERDOMAIN.md I am really wondering...

I'll keep you posted.

KaiSchwarz-cnic commented 3 years ago

What is the exact domain name used within your transfer request?

ikitaez commented 3 years ago

And i have question about additional fields in version 6, is it possible to control them somehow like it was in version 5 in additionalfields.php file? I tried it same way like it was in version 5 and it not working.

ikitaez commented 3 years ago

What is the exact domain name used within your transfer request?

*.hk

KaiSchwarz-cnic commented 3 years ago

And i have question about additional fields in version 6, is it possible to control them somehow like it was in version 5 in additionalfields.php file? I tried it same way like it was in version 5 and it not working.

Actually not. If this is of interest, I can note down to check if we can realize a customizing possibility (should be possible somehow). Our approach makes additional fields fully translatable and no need to apply custom configurations there, having it working out of the box.

Thanks for providing the domain name.

KaiSchwarz-cnic commented 3 years ago

Have you had successful .hk transfers in the past with us? I checked also the v5 release branch for an oversight on my end. But there, we have also just the additional domain fields configured as we have them configured right now. No removal of some .hk flags before command is being send to our api (of course we didn't send fields with hk transfers, but looks like flags are necessary). If so, would you mind pointing me to a domain name you used? I continue in the meanwhile working on this issue.

ikitaez commented 3 years ago

No, its first transfer for .hk for us with your module

KaiSchwarz-cnic commented 3 years ago

Just in case this is an urgent case: Just initiate the transfer using our web interface at https://account.hexonet.net. WHMCS should identify the transfer as processed later. You then need to care about contact updates after that process. WHMCS is always including contact data in transfer process which is different to how our web interface is handling transfers and therefore it is there much easier and not as complex regarding additional fields.

I am just forwarding this idea, because I expect this issue to take a bit longer on our end.

ikitaez commented 3 years ago

Okay, thanks. (And yes, i tried v5, it was not working there also).

KaiSchwarz-cnic commented 3 years ago

Hi @ikitaez,

.HK Transfer should be working now. .HK is like other TLDs very specific and requires a Trade for Change of Registrant. That's why we ignore the contact data provided for the transfer process. Still, if necessary a contact update has to be made after having the transfer process finished then. That's nothing special to HEXONET, "Trade" processes are something the registry provider is enforcing for the change of registrant. In general, the better way is to not combine Contact Update and Transfer into one process and to separate it in two processes.

Find v6.1.4 here.

HTH

Best Kai