Unite `Investment` and `ForeignInvestment` traits

[wischli]

Description

• Existing Investment and ForeignInvestment traits are mainly overlapping, should be merged
• Outcome should incorporate InvestmentCollector as well

Research/based on

• https://github.com/centrifuge/centrifuge-chain/pull/1473#discussion_r1299780528
• https://github.com/centrifuge/centrifuge-chain/pull/1473#discussion_r1306958688

How will this affect the code base

• More boilerplate for pallet-investments impl of Investment
• Less complexity and noise overall

What are foreseen obstacles or hurdles to overcome?

• Introduce more errors to pallet-investments impl for mismatching currencies

[lemunozm]

What's the idea of getting this merged too? Is implementing the foreign trait for pallet-investment using the same currency for foreign and pool?

[wischli]

I envision this to based on your proposal and focused on supporting foreign and pool currency whereas the pallet-investment impl of the trait uses the same currency.

[lemunozm]

Ok, then what I said in my previous message I think, makes no sense. I thought the issue was referred to another thing 😅.