centrumek / duolingo-readme-stats

📗🧑‍🎓 Dynamically generated duolingo.com stats for your README.md
MIT License
5 stars 2 forks source link

Some languages do not get their proper emoji. #4

Open RichardKanshen opened 4 months ago

RichardKanshen commented 4 months ago

The issue is simple - languages like Norwegian Bokmål do not get a proper emoji. This could be solved with a simple list of images / emojis corresponding to the course titles, instead of relying on an external library.

RichardKanshen commented 4 months ago

For context, it looks kind of like this: image

RichardKanshen commented 4 months ago

After a couple changes, I got it working with custom svgs for emojis, as well as streak and xp icons image

centrumek commented 4 months ago

Hi @RichardKanshen , wow thank you for this PR I'll review it very soon :)

RichardKanshen commented 3 months ago

After some more tinkering, I also got "from Language" text working, which shows the flag of the base language. Can be disabled for English with SHOW_FROM_ENGLISH option in YAML. With English shown: image Without English Shown: image

RichardKanshen commented 3 months ago

Another thing - Added leagues! They require two user cookies to be passed via GitHub Secrets, but they finally work! image

RichardKanshen commented 3 months ago

Also, since I added the cookies option, I also added XP earned since last leaderboard reset. image

RichardKanshen commented 3 months ago

Also added the inactive streak icon (updates based on the user timezone)

day 129 before streak extension: image day 129 after streak extension: image day 130 before streak extension: image

RichardKanshen commented 3 months ago

Added Streak Freeze icon if the streak has been frozen, too! image

RichardKanshen commented 3 months ago

Added the option to show the timezone in which Streak is counted. image

centrumek commented 1 month ago

Hi @RichardKanshen, I apologise for my long review, I'll try to make it this week :).

Wow, what's an update till that time