search

cepdnaclk / portal.ce.pdn.ac.lk

Internal and Public web service provider of the Department of Computer Engineering
MIT License
2 stars 1 forks source link

[UI,BE] Code cleanup - course related modules #143

Open NuwanJ opened 6 days ago

NuwanJ commented 6 days ago

Please check if there any residual code blocks (Specially JS codes) no longer in use and cleanup.

NuwanJ commented 5 days ago

@IsharaEkanayaka Please update this branch with the latest changes from course-management-system. I can see some functionalities not working after recent PR with I assume alpine change. Thanks!

IsharaEkanayaka commented 5 days ago

can you tell me the not working functionality so that it is easier to fix it. https://github.com/user-attachments/assets/a72500c3-706c-4e84-a873-d82a69e042bd reason for this error is quill editor is not used for course/ semester pages. Now i have removed quill initialization from app.blade.php . now that error is not showing.

On Sun, Sep 22, 2024 at 9:03 AM Nuwan Jaliyagoda @.***> wrote:

@IsharaEkanayaka https://github.com/IsharaEkanayaka Please update this branch with the latest changes from course-management-system. I can see some functionalities not working after recent PR with I assume alpine change. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/cepdnaclk/portal.ce.pdn.ac.lk/issues/143#issuecomment-2365442811, or unsubscribe https://github.com/notifications/unsubscribe-auth/A72LWBCOSZWKLU2J2YMHJNLZXY3CNAVCNFSM6AAAAABOTYQ5PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGQ2DEOBRGE . You are receiving this because you were mentioned.Message ID: @.***>

NuwanJ commented 4 days ago

My bad, I was in sleeping mode. Here is the issue I found:

Image

Either the Next Button is not working or no Validation errors are shown. I can't go to the second page

NuwanJ commented 4 days ago

I merged the latest changes in course-management branch with this, so you can see it. It might be due to conflict of 2 PRs