ceph / ceph-csi

CSI driver for Ceph

Apache License 2.0

1.29k stars 550 forks source link

Implement GetFenceClients to return the ceph clusterID and the client Address #4944

Closed Madhu-1 closed 3 weeks ago

Madhu-1 commented 3 weeks ago

This PR implements a csiaddons RPC calls to return the ceph fsID and the client IP that is used to connect to the ceph cluster from the rbd plugin daemonset pod.

closes: #4913

Madhu-1 commented 3 weeks ago

Test result

sh-5.1# csi-client 
Enter the path for the Unix socket: unix:///csi/csi-addons.sock
Using socket path: unix:///csi/csi-addons.sock
Server response: id:"a815fe8e-eabd-4e87-a6e8-78cebfb67d08"  addresses:{cidr:"10.244.0.1"}
sh-5.1# cat /sys/devices/rbd/0/
block/        client_id     config_info   features      major         name          pool          pool_ns       refresh       snap_id       uevent        
client_addr   cluster_fsid  current_snap  image_id      minor         parent        pool_id       power/        size          subsystem/    
sh-5.1# cat /sys/devices/rbd/0/client_addr 
10.244.0.1:0/353261872
sh-5.1# cat /sys/devices/rbd/0/cluster_fsid 
a815fe8e-eabd-4e87-a6e8-78cebfb67d08
sh-5.1#

wrote a small client to get the details, this is how it looks like

nixpanic commented 3 weeks ago

cidr:"10.244.0.1" is not in correct CIDR notation, it is a plain IP-address. Maybe call it differently, or make it cidr:"10.244.0.1/32".

Madhu-1 commented 3 weeks ago

cidr:"10.244.0.1" is not in correct CIDR notation, it is a plain IP-address. Maybe call it differently, or make it cidr:"10.244.0.1/32".

added /32 to make it CIDR.

Madhu-1 commented 3 weeks ago

hfs nodeplugin needs this NF server too

This is only for rbd now, we will extend it to cephfs later on if required.

nixpanic commented 3 weeks ago

@mergifyio rebase

mergify[bot] commented 3 weeks ago

rebase

✅ Branch has been successfully rebased

nixpanic commented 3 weeks ago

@mergifyio queue

mergify[bot] commented 3 weeks ago

queue