search

cerner / cucumber-forge-report-generator

Cucumber Feature Reports Made Easy
Apache License 2.0
6 stars 6 forks source link

feature: add dark mode checkbox (part 2/2) of the following request #63

Closed lendkhoa closed 3 years ago

lendkhoa commented 4 years ago

This pull request adds a check box to control the toggling of dark mode feature https://github.com/cerner/cucumber-forge-desktop/pull/58/

jkuester commented 3 years ago

Okay, I apologize for the confusion here. I think that I must have missed how things ultimately turned out on https://github.com/cerner/cucumber-forge-desktop/pull/58. For some reason I thought that PR had added the toggle box to the Settings pane for the app (https://github.com/cerner/cucumber-forge-desktop/blob/b3a1e3cb963aa19ed70c4b1f8555cc79fa6e24ea/src/index.html#L79). The darkmode-js changes in cucumber-forge-desktop will only work when actually using the app itself (and not when just viewing the HTML reports in a web browser). So, the toggle for that setting needs to stay in the app Settings (and not be added to the actual report HTML).

Ultimately, we do want to add a toggle like what you have here to the actual report HTML setting drawer, but it needs to come with a general fix for https://github.com/cerner/cucumber-forge-report-generator/issues/3 that will handle toggling the actual css colors of the report itself. This would make it so that the dark mode would also work in any web browser that is viewing the report.

lendkhoa commented 3 years ago

I see. In that case, I'll close this PR and create another for cucumber-forge-desktop to add the toggle box to the setting.