search

cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook
Apache License 2.0
102 stars 405 forks source link

update cert-manager version and kubebuilder #36

Closed roytev closed 2 years ago

roytev commented 2 years ago

now tests works on MacOs Monterey fixes #33
Signed-off-by: Roi Teveth roytev@gmail.com

jetstack-bot commented 2 years ago

Hi @roytev. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
roytev commented 2 years ago

Hi @inteon and @munnerz can you review please? :)

munnerz commented 2 years ago

/ok-to-test

roytev commented 2 years ago

/retest

roytev commented 2 years ago

@munnerz the build if failed because of https://github.com/clarketm/json/issues/5 so i upgraded it to go1.17 can you please change the prow build to 1.17?

munnerz commented 2 years ago

You should be able to make a PR over here to change the Go version 😄 https://github.com/jetstack/testing/blob/master/config/jobs/cert-manager/webhook-example/cert-manager-webhook-example-presubmits.yaml

On Tue, 8 Feb 2022 at 09:12, Roi @.***> wrote:

@munnerz https://github.com/munnerz the build if failed because of clarketm/json#5 https://github.com/clarketm/json/issues/5 so i upgraded it to go1.17 can you please change the prow build to 1.17?

— Reply to this email directly, view it on GitHub https://github.com/cert-manager/webhook-example/pull/36#issuecomment-1032378139, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRWP2HMQU5NDON4THFMLTU2DM6PANCNFSM5NZXKWZA . You are receiving this because you were mentioned.Message ID: @.***>

roytev commented 2 years ago

/retest

roytev commented 2 years ago

/retest

roytev commented 2 years ago

/test all

wallrj commented 2 years ago

/retest

wallrj commented 2 years ago

@roytev We resubmitted the failed webhook after you merged https://github.com/jetstack/testing/pull/625 but the prow job config still hasn't been updated. We're chatting about it in Slack https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1644322122722629 if you want to follow along.

roytev commented 2 years ago

/retest

roytev commented 2 years ago

/retest

wallrj commented 2 years ago

/retest

roytev commented 2 years ago

/assign @jakexks

jetstack-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, roytev, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/webhook-example/blob/master/OWNERS)~~ [wallrj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment