search

cert-manager / webhook-example

A cert-manager sample repository for creating an ACME DNS01 solver webhook
Apache License 2.0
102 stars 405 forks source link

Bump deps + fix makefile #56

Closed SgtCoDFish closed 10 months ago

SgtCoDFish commented 10 months ago

  1. Bumps deps to fix https://github.com/advisories/GHSA-qppj-fm5r-hxr3 / https://github.com/advisories/GHSA-4374-p667-p6c8 (and also bumps cert-manager, which requires a test fix)

  2. Fixes makefile targets. See that commit message for more details - basically, the makefile wouldn't respect a new version of kubebuilder test tools, and it used .PHONY incorrectly. This should mean that the Makefile will be easier and less confusing to use.

  3. Bumps builder + base images for actually building the thing!

inteon commented 10 months ago

/approve /lgtm

jetstack-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cert-manager/webhook-example/blob/master/OWNERS)~~ [inteon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment