cescalara / fancy

UHECR modelling and fitting tools
BSD 3-Clause "New" or "Revised" License
4 stars 6 forks source link

Implementation of directional GMF model #29

Closed kwat0308 closed 4 months ago

kwat0308 commented 1 year ago

This branch allows analysis for the new directional GMF model. This is already updated with the new composition loss model.

Again, I create a PR to ta_updates for now.

kwat0308 commented 1 year ago

Same here, both branches (add-ptypes and Nex-calc-gmf) are merged as well. There is an issue with the checks due to the py3.8 tests.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (5373974) 0.00% compared to head (ec6e7f6) 0.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## ta_updates #29 +/- ## ========================================== Coverage 0.00% 0.00% ========================================== Files 34 34 Lines 3182 3189 +7 ========================================== - Misses 3182 3189 +7 ``` | [Files](https://app.codecov.io/gh/cescalara/fancy/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Francesca+Capel) | Coverage Δ | | |---|---|---| | [fancy/analysis/analysis.py](https://app.codecov.io/gh/cescalara/fancy/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Francesca+Capel#diff-ZmFuY3kvYW5hbHlzaXMvYW5hbHlzaXMucHk=) | `0.00% <0.00%> (ø)` | | | [fancy/interfaces/uhecr.py](https://app.codecov.io/gh/cescalara/fancy/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Francesca+Capel#diff-ZmFuY3kvaW50ZXJmYWNlcy91aGVjci5weQ==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cescalara commented 8 months ago

@kwat0308, does this PR need updating or are you waiting on my review?

kwat0308 commented 8 months ago

Reviewing the commits, I think that this can be merged with ta_updates. So once you review it I think we can push this 👍