Closed kwat0308 closed 4 months ago
Same here, both branches (add-ptypes
and Nex-calc-gmf
) are merged as well. There is an issue with the checks due to the py3.8 tests.
Attention: 27 lines
in your changes are missing coverage. Please review.
Comparison is base (
5373974
) 0.00% compared to head (ec6e7f6
) 0.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@kwat0308, does this PR need updating or are you waiting on my review?
Reviewing the commits, I think that this can be merged with ta_updates
. So once you review it I think we can push this 👍
This branch allows analysis for the new directional GMF model. This is already updated with the new composition loss model.
Again, I create a PR to ta_updates for now.