search

cetic / helm-nifi

Helm Chart for Apache Nifi
Apache License 2.0
215 stars 228 forks source link

Support NIFI_SENSITIVE_PROPS_KEY environment variable #183

Closed wknickless closed 2 years ago

wknickless commented 3 years ago

What this PR does / why we need it:

As of NiFi 1.14.0 the nifi.sensitive.props.key property must be defined (see https://issues.apache.org/jira/browse/NIFI-8230). This PR provides support and documentation for setting that property from an environment variable injected from a Kubernetes secret.

Special notes for your reviewer:

Includes a fix for if/then/else scope bug that only included envFrom when postStart was enabled.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

banzo commented 3 years ago

@zakaria2905 please check if/how this is included in #169

zakaria2905 commented 3 years ago

The bug in statefulset has been fixed in the last review (thank for your report) #169

The secret for the sensitive key will be add in the next update.

wknickless commented 2 years ago

Closing this pull request, will rebase against the current release.