search

ceylon / ceylon-module-resolver

DEPRECATED
Apache License 2.0
23 stars 9 forks source link

Use the actual output repo in default list of input repos #119

Open FroMage opened 9 years ago

FroMage commented 9 years ago

Right now ./modules gets added to the default input repo list even when we change the output repo with --out. I think the output repo should be used in the default input repo list, whether defaulted or specified. But if we specify it, we should use what the user specified, not ./modules.

If the user wants both his output repo and ./modules he can add it manually.

quintesse commented 9 years ago

I'm not sure I agree. To me currently all ceylon commands that deal with repositories, regardless if they have an --out option or not look up any modules they need from ./modules (unless overridden by --rep). That the compilers have an --out option, to me, only changes where the output module should be written to, it should IMO not affect where it looks up modules.

So in short, --rep affects the lookup of modules, -out affects where the output gets written.

(Even if this explanation is not entirely correct technically speaking I think it will cause the least surprises, the --out option affecting lookup does)

FroMage commented 9 years ago

Well, it really depends. IMO we add the output repo to the default list of input repos, which makes sense. But that should be the output repo, and not ./modules.