search

cfengine / design-center

CFEngine community-contributed content
http://cfengine.com/
Other
80 stars 68 forks source link

cf-sketch: fix relocate_path and use it in the tools/test/Makefile #450

Closed tzz closed 9 years ago

tzz commented 9 years ago

This enables relocate_path again, making it possible to use DC with relocated inputs.

tzz commented 9 years ago

@nickanderson @estenberg I hope this is acceptable. See discussion in mailing list.

tzz commented 9 years ago

I added a commit to remove --test=any from the test Makefile and the test key from the DC API, since test mode was removed recently in #448. That commit can be done in a separate PR if you want.

tzz commented 9 years ago

ping?

nickanderson commented 9 years ago

For reference here is the thread on the mailing list: https://groups.google.com/d/msg/help-cfengine/NN_NuVrsnvU/1b4qcBAnaeIJ

It seems fine to me, but I don't know the code well. @estenberg ?

tzz commented 9 years ago

ping

tzz commented 9 years ago

ping @estenberg

estenberg commented 9 years ago

Intention is good but I don't have much to say about the code.. Only thing I'm worrying about is breakage of existing DC usage.

tzz commented 9 years ago

The default behavior is same as before. It's only changed if the user explicitly requests relocate_path=/a/b/c/whatever from the API.

estenberg commented 9 years ago

OK, what can go wrong... :)