search

cfpb / amortize

A node module to calculate the interest paid, principal paid, remaining balance, and monthly payment of a loan.
Creative Commons Zero v1.0 Universal
58 stars 19 forks source link

Added principalBreakingTerm #15

Closed avantassel closed 6 years ago

avantassel commented 6 years ago

Added principalBreakingTerm to know when principals payments will be more than interest payments

codecov[bot] commented 6 years ago

Codecov Report

Merging #15 into master will increase coverage by 0.24%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   94.91%   95.16%   +0.24%     
==========================================
  Files           1        1              
  Lines          59       62       +3     
  Branches       13       14       +1     
==========================================
+ Hits           56       59       +3     
  Misses          3        3
Impacted Files Coverage Δ
index.js 95.16% <100%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 032c295...cf934d9. Read the comment docs.

ascott1 commented 6 years ago

Hi @avantassel overall this looks like a good change. Thank you, much appreciated! 🎊

I left a few minor comments. Once those are addressed and @contolini chimes in with a review, we can merge this in. After that we'll bump the version number and publish a new release.

contolini commented 6 years ago

Thanks @avantassel! I squashed this into https://github.com/cfpb/amortize/commit/b946c36dcfbc77f309fcf3658ef64751a1a146d4 and published it under v1.1.0.