search

cfpb / design-system

CFPB's work-in-progress design system
https://cfpb.github.io/design-system
Creative Commons Zero v1.0 Universal
42 stars 13 forks source link

Remove unused Lighthouse results upload #2081

Closed chosak closed 3 weeks ago

chosak commented 3 weeks ago

A nightly GitHub Action runs Lighthouse against the Design System documentation site, to ensure that it meets with accessibility guidelines.

Currently this Action is generating a warning message, for example:

No files were found with the provided path: .lighthouseci. No artifacts will be uploaded.

This warning occurs because the upload step can't find the Lighthouse results.

We don't actually use the raw Lighthouse results in any way; as part of the nightly test, HTML reports are uploaded to temporary Google storage and their public URLs are included in the Action log.

Thus there's no need to upload the raw run results. This commit removes the upload step, thus fixing the warning.

netlify[bot] commented 3 weeks ago

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
Latest commit 0fae44b06099277c5e7ac6118209c1f9bc46502f
Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/671f97ebc734560007ab2815
Deploy Preview https://deploy-preview-2081--cfpb-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.