cfpb / django-flags

Feature flags for Django projects
https://cfpb.github.io/django-flags/
Creative Commons Zero v1.0 Universal
260 stars 32 forks source link

Boolean values don't account for errant spaces #27

Closed chosak closed 5 years ago

chosak commented 5 years ago

(Relocated from https://github.com/cfpb/wagtail-flags/issues/18 after repository was split up in https://github.com/cfpb/wagtail-flags/pull/29.)

The current boolean test won't succeed if there is a space in the condition value. The test should probably be something to the effect of 'true' in condition.lower() to provide more latitude in string possibilities. Or it should provide some value validation.