search

cfpb / django-flags

Feature flags for Django projects
https://cfpb.github.io/django-flags/
Creative Commons Zero v1.0 Universal
260 stars 32 forks source link

Add notes to the docs about fallback view arguments #38

Closed willbarton closed 5 years ago

willbarton commented 5 years ago

Fallback views must take the same arguments and keyword arguments as the corresponding flagged view. This change adds that explicitly to the docs in all the places where the option exists to provide a fallback.

These admonitions look like:

image
willbarton commented 5 years ago

@higs4281 Yeah. I think I'm going to document that separately after I write some tests to remember exactly why it shouldn't be done, and to maybe provide some erroring/warning about it.