Closed callorico closed 6 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
flags/tests/test_forms.py | 8 | 9 | 88.89% | ||
<!-- | Total: | 12 | 13 | 92.31% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
flags/urls.py | 2 | 100.0% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 56: | -0.1% |
Covered Lines: | 763 |
Relevant Lines: | 764 |
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
flags/tests/test_forms.py | 8 | 9 | 88.89% | ||
<!-- | Total: | 12 | 13 | 92.31% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
flags/urls.py | 2 | 95.65% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 38: | -0.4% |
Covered Lines: | 761 |
Relevant Lines: | 764 |
@callorico Thanks! I'll make sure it gets a review, but for now #6 should fix the Travis error if you rebase or update from master.
Thanks. I've rebased.
Previously, the FlagStateForm condition choices were bound when the module was loaded. It is possible for this happen before custom conditions in other Django apps have been registered.
This commit delays populating the choices until the form is created. This allows all custom conditions to be registered first.