search

cfpb / django-flags

Feature flags for Django projects
https://cfpb.github.io/django-flags/
Creative Commons Zero v1.0 Universal
260 stars 32 forks source link

Format with black #56

Closed willbarton closed 4 years ago

willbarton commented 4 years ago

This commit has had black, the autoformatter, run on the flags package and setup.py

It also adds black --check to the tox lint environment and adds a section in CONTRIBUTING.md about code style and tools.

willbarton commented 4 years ago

I have no big objection, but the vast majority of black-enforced changes are single-quote/double-quote swaps, which I see little value in

Yeah, black is highly opinionated about quotes. There's a switch to ignore single/double quotes, but I feel like if we're going to embrace an auto formatter, we should embrace it.

willbarton commented 4 years ago

Re: quote normalization, we coooould skip it 😁

👇

I feel like if we're going to embrace an auto formatter, we should embrace it.

And this might be in conflict with my comment above about line-length 😁