cfrg / draft-irtf-cfrg-voprf

Oblivious Pseudorandom Functions (OPRFs) using Prime-Order Groups
https://cfrg.github.io/draft-irtf-cfrg-voprf/#go.draft-irtf-cfrg-voprf.html
Other
39 stars 15 forks source link

Scalar structure is not clearly defined #196

Closed claucece closed 4 years ago

claucece commented 4 years ago

The Scalar structure is first used on the Data Structures section, and not previously defined, and it is used as: Scalar blind<1..2^16-1>;, which seems to imply this is the serialized scalar.

It is later defined as: This document uses the types Element and Scalar to denote elements of the group GG and its underlying scalar field GF(p), respectively., which seems to imply it is the underlying reprensentation.

It is not clear what it is referred to.

chris-wood commented 4 years ago

I think we should just say Scalar refers to an actual scalar element for the group. It seems the only time we need to serialize and send a scalar on the wire is for the proof, so we can have a SerializedScalar type (similar to SerializedElement) for that.

armfazh commented 4 years ago

Similar to #139

chris-wood commented 4 years ago

@claucece, can we close this now that #190 is merged?

chris-wood commented 4 years ago

Closing as resolved. @claucece, please re-open if this still needs to be fixed!