search

cgag / loc

Count lines of code quickly.
MIT License
2.31k stars 126 forks source link

mmap build failure on windows #13

Closed zackschuster closed 7 years ago

zackschuster commented 7 years ago

Tried installing twice. Build fails with E0432 and E0061 errors [log gist]. There aren't any issues in mmap's repo that point to a similar problem, but the project's been dormant for 2 years.

cgag commented 7 years ago

No issue but there is a (old :() pr to fix these issues: https://github.com/rbranson/rust-mmap/pull/1

I can't remember why I chose this over the other mmap library. I'll have to revisit that decision. I'll see if I can sub it out soon, I'd really like to see this work on windows.

zackschuster commented 7 years ago

I can hack on a PR for that when I get off work. At the very least get some idea of how much effort would go into the refactor.

cgag commented 7 years ago

That'd be great. burntsushi mentioned on reddit that this is crate the community has defacto standardized around: https://github.com/danburkert/memmap-rs

zackschuster commented 7 years ago

Yeah I saw that referenced in issue 5 for mmap. At the very least, it's definitely more active 😄

cgag commented 7 years ago

fixed her: https://github.com/cgag/loc/pull/17