search

cgag / loc

Count lines of code quickly.
MIT License
2.31k stars 126 forks source link

implement support for Gherkin #47

Closed mroth closed 7 years ago

mroth commented 7 years ago

Gherkin is a language commonly used for writing BDD style tests, with parsers in a dozen+ different languages. It is part of the Cucumber project.

https://github.com/cucumber/cucumber/wiki/Gherkin

mroth commented 7 years ago

Not sure what's going on with travis-ci here, but the error appears to be with the pre-installation of the build scripts, not the tests or anything touched by this patch...

(Error: The command "bash ci/install.sh" failed and exited with 127, looking at the output closer it appears to be failing when trying to uninstall the travis-ci version of Rust)

cgag commented 7 years ago

Yeah travis seems to have broken somehow and I haven't been not-lazy enough to fix it. This looks good at a glance so i'm just going to merge it. I mean, it's even got a test I think you're the first person besides me to add one. Awesome, thanks.

mroth commented 7 years ago

@cgag Thanks! One semi-unrelated question -- is the travis bug what is blocking new versioned releases?

I'd love to use this with some projects at my day job as well, but we don't work a Rust environment there, being able to brew install or download a binary is important -- and we would need a more recent version than 0.3.4 due to this patch and (more importantly) the .gitignore fix from c8b20c9.

Let me know -- I am not very experienced with Rust, but will still offer to try to help you troubleshoot travis if you would like.

cgag commented 7 years ago

I've just been being lazy. I'd love help but I think it's fairly straight forward (it looks like the project I used, rust-everywhere, has been deprecated in favor of https://github.com/japaric/trust) and involves a lot of twiddling with API keys. I'll try to get that setup sometime this week or next weekend and push a release.