search

cgarling / StarFormationHistories.jl

Fitting astrophysical star formation histories via CMD modelling.
MIT License
3 stars 0 forks source link

One-based indexing #1

Closed cgarling closed 1 year ago

cgarling commented 1 year ago

Most of the methods assume one based indexing but accept abstract array types (e.g., AbstractVector). Prior to release we should check this assumption with Base.require_one_based_indexing on the input arrays, or try to generalize the indexing, but I suspect that will not be worth the work.

cgarling commented 1 year ago

For now I'm moving away from allowing abstract array types to requiring the concrete types from base (i.e. Vector instead of AbstractVector). This might limit some use cases in the future (e.g., using StaticArrays) but for now it should be an adequate safeguard.

cgarling commented 1 year ago

A lot of these cases have been opened up to allow AbstractVectors, AbstractMatrix, etc. now.