cgravolet / scroblr

A lightweight browser extension that scrobbles the music you listen to on the web.
http://scroblr.fm
Other
230 stars 62 forks source link

Wrong album is scrobbled #26

Open cgravolet opened 11 years ago

cgravolet commented 11 years ago

When requesting track information, last.fm occasionally sends back a different album than the one specified by the plugins scrape method. Since scroblr uses the track.getInfo response to display album art, it occasionally changes the album name so they match.

Instead of using album information from the track.getInfo response, it should do an album.getInfo request to get the album art. Only when that request fails, or no album was specified, should it default to the album from the track.getInfo response.

BinaryKhaos commented 9 years ago

I suspect this is related to the problem I am seeing right now as well, so I am not opening a new issue.

Example:

I checked from the dev console, the album-title is set correctly, so the plugin gets the correct information. Scrobbling the same title from the Spotify client (not the web player) works just fine and last.fm records the scrobble for the correct track and album, so it is definitely not a last.fm problem but seems to be related to how scroblr deals with the data returned from last.fm (the album and track title are exactly the same on Spotify and Google Play Music by the way).

Editing the album title through scroblr while the track is playing, scrobbles it correctly as well. Unfortunately this is obviously not really a good solution. :-)