chaijs / chai-http

HTTP Response assertions for the Chai Assertion Library.
http://chaijs.com/plugins/chai-http
633 stars 113 forks source link

fix: add superagent types as prod dependency #347

Closed 43081j closed 1 week ago

43081j commented 2 weeks ago

We expose superagent's types in our own types, so this should be a production dependency. Otherwise, we will cause errors in the typescript builds of consumers (unless they skip lib check).

It does mean we add an unnecessary dependency for non-ts people, but there's not any simple way around that.

Fixes #346

jthemphill commented 1 week ago

Thank you!

jthemphill commented 1 week ago

unless they skip lib check

I think we do skip lib check... the issue is that our own project doesn't typecheck because we're relying on types that we couldn't find in our dependency tree.