search

chainguard-dev / actions

A collection of reusable Github Actions workflows.
Apache License 2.0
119 stars 57 forks source link

Add git repo URL and commit SHA parameters #485

Closed sgalsaleh closed 1 month ago

sgalsaleh commented 1 month ago

Allows providing the URL of the git repository and the commit SHA containing the build config file.

Needed due to this change: https://github.com/chainguard-dev/melange/commit/eab3401f8019e134af6fe070e4d4bcff57993d30

imjasonh commented 1 month ago

LGTM, thanks

For context, we don't use this action ourselves, so it's likely that this will at least trail melange features, and at worst break completely if there are breaking changes to melange that aren't accounted for in this action.

I'd recommend forking this action and making your changes there in general, and taking care to pin and bump melange releases in calls to this, instead of using the latest melange.

That being said, this LGTM ✅

sgalsaleh commented 1 month ago

Sounds good, thanks!

sgalsaleh commented 1 week ago

@imjasonh we want to stop using the github actions, but any reason the latest releases of melange do not include assets / binaries? https://github.com/chainguard-dev/melange/releases/tag/v0.15.5