search

chainguard-dev / actions

A collection of reusable Github Actions workflows.
Apache License 2.0
119 stars 57 forks source link

bug(setup-melange): account for not all releases having assets #493

Open ricardomaraschini opened 1 week ago

ricardomaraschini commented 1 week ago

it is not all releases that have assets, so we need to account for that. for example, the release v0.15.7 has no assets so this action fails when downloading the melange binary.

the logic here is as follows (only when version latest-release is used):

[!NOTE]
maybe generate assets always or flagging releases without assets as pre-releases would make things easier.

emosbaugh commented 1 week ago

Another approach would be to allow for passing a version here

ricardomaraschini commented 1 week ago

Another approach would be to allow for passing a version here

Yes, I opened https://github.com/chainguard-dev/actions/pull/492 yesterday.