search

chainguard-dev / apko

Build OCI images from APK packages directly without Dockerfile
https://apko.dev
Apache License 2.0
1.21k stars 125 forks source link

Pass errors up the stack in CalculateWorld and InstallPackages #1404

Closed smoser closed 1 week ago

smoser commented 1 week ago

Make sure to close channel in InstallPackages, cleanup in CalculateWorld

This problem was found in melange https://github.com/chainguard-dev/melange/issues/1645

Any time a download failed, we would hang waiting for a close that would never occur.

luhring commented 1 week ago

@jonjohnsonjr This looks up your alley 👀