search

chainside / btcpy

A Python3 SegWit-compliant library which provides tools to handle Bitcoin data structures in a simple fashion.
https://www.chainside.net
GNU Lesser General Public License v3.0
270 stars 73 forks source link

Support for altcoins #16

Closed oskyk closed 6 years ago

oskyk commented 6 years ago

Support for dash and litecoin it is probably just changing a few constants

peerchemist commented 6 years ago

There is a branch here with Peercoin support: https://github.com/PeerAssets/btcpy/tree/ppc

However this has to be done differently. I imagine it as passing dict of parameters to setup function.

SimoneBronzini commented 6 years ago

I don't think this should be a general purpose altcoin library. I believe a better approach would be the same @peerchemist is using: everyone who wants to develop an altcoin version of this library can fork it and work on it. This prevents the problem of having to update btcpy with new and possibly heavy changes as soon as any altcoin deploys a new feature. In that case, that altcoin's fork can be updated leaving the code for the other coins unchanged.

l0rb commented 6 years ago

Maybe the pull could be modified so that it would support just btc but making it easier to add other coins.

SimoneBronzini commented 6 years ago

That would be welcome!