chainside / btcpy

A Python3 SegWit-compliant library which provides tools to handle Bitcoin data structures in a simple fashion.
https://www.chainside.net
GNU Lesser General Public License v3.0
270 stars 73 forks source link

Native b58 implementation #24

Closed peerchemist closed 6 years ago

peerchemist commented 6 years ago

All unittests are passing.

SimoneBronzini commented 6 years ago

Thanks for your PR! The code looks fine, however I believe we should have more thorough testing, base58 being a very important core part of the system. Some base58 test vectors can be found at the following links:

One more thing: I see the test class is called P2THTest and the same is printed at test setUpClass. I guess that is the wrong name for these tests.

peerchemist commented 6 years ago

We've been using this b58 implementation for well over a year in the pypeerassets project. I've simply copied the code over and implemented a test in unittest (we use pytest here).

peerchemist commented 6 years ago

Expanded the unittest.