Closed peerchemist closed 6 years ago
Thanks for your PR! The code looks fine, however I believe we should have more thorough testing, base58 being a very important core part of the system. Some base58 test vectors can be found at the following links:
unhexlify
ed before encoding and hexlify
ed after decoding to be compared)One more thing: I see the test class is called P2THTest
and the same is printed at test setUpClass
. I guess that is the wrong name for these tests.
We've been using this b58 implementation for well over a year in the pypeerassets project. I've simply copied the code over and implemented a test in unittest (we use pytest here).
Expanded the unittest.
All unittests are passing.