search

chainside / btcpy

A Python3 SegWit-compliant library which provides tools to handle Bitcoin data structures in a simple fashion.
https://www.chainside.net
GNU Lesser General Public License v3.0
270 stars 73 forks source link

As TransactionParser is dealing with a stream, it's methods should.. #3

Closed peerchemist closed 7 years ago

peerchemist commented 7 years ago

… not be public getters but private methods.

SimoneBronzini commented 7 years ago

Thanks for the PR, your suggestion makes perfect sense. However, I usually prefer single underscores on private methods to avoid name mangling. I will merge your PR with single underscores as soon as I have added some tests on Block parsing, which I am in the process of doing.