chainside / btcpy

A Python3 SegWit-compliant library which provides tools to handle Bitcoin data structures in a simple fashion.
https://www.chainside.net
GNU Lesser General Public License v3.0
270 stars 73 forks source link

Pb of syntax with version 0.5 #38

Closed LaurentMT closed 6 years ago

LaurentMT commented 6 years ago

Hi,

I've just installed the latest version (0.5) in a Python 3.3 environment. Installation returns a few warnings suggesting syntax problems.

   Installing collected packages: chainside-btcpy, ecdsa
   Running setup.py install for chainside-btcpy
     D:\tools\python333\python.exe c:\users\admin\appdata\local\temp\tmptmxbw0.py
       File "D:\tools\python333\Lib\site-packages\btcpy\setup.py", line 26
         return func(*args, **kwargs, strict=strict)
                           ^
     SyntaxError: invalid syntax

       File "D:\tools\python333\Lib\site-packages\btcpy\structs\script.py", line 774
         return [int(m), *pubkeys, int(n)]
                         ^
     SyntaxError: can use starred expression only as assignment target

       File "D:\tools\python333\Lib\site-packages\tests\integration.py", line 132
         self.instance = self.get_script_cls()(*self.get_args(), *args, *scripts)
                                                   ^
     SyntaxError: invalid syntax

     removing c:\users\admin\appdata\local\temp\tmptmxbw0.py
     D:\tools\python333\lib\distutils\dist.py:257: UserWarning: Unknown distribution option: 'python_requires'
       warnings.warn(msg)

Problem is confirmed if I try to run a script calling the setup() function.

File "D:\tools\python333\lib\site-packages\btcpy\setup.py", line 26
   return func(*args, **kwargs, strict=strict)
                              ^
SyntaxError: invalid syntax

Does it mean that Python 3.3 isn't supported anymore ?

SimoneBronzini commented 6 years ago

Thanks for pointing this out, we actually count to support python3.3 for a long time, so I am going to fix this right now