search

chainwayxyz / citrea

Citrea, Bitcoin's First ZK Rollup 🍊🍋
https://citrea.xyz
GNU General Public License v3.0
127 stars 26 forks source link

Don't panic, return Err on sov-tx deserializtion or signature errors #1061

Open eyusufatik opened 2 months ago

eyusufatik commented 2 months ago

see this issue in codebase

rakanalh commented 2 months ago

Can you please link to the line mentioning the issue?

eyusufatik commented 2 months ago

There is panic's here: https://github.com/chainwayxyz/citrea/blob/578594afd7b0edb66fa2735d31b7592db3ef4c9e/crates/sovereign-sdk/module-system/sov-modules-stf-blueprint/src/stf_blueprint.rs#L84

though this issue can be done closer to a planned fork, since it'll cause a fork.