search

chaisql / chai

Modern embedded SQL database
MIT License
1.56k stars 95 forks source link

select: return error if field doesn't exist on tables with strict schema #477

Closed tzzed closed 11 months ago

tzzed commented 2 years ago

This PR fixes #465.

codecov[bot] commented 2 years ago

Codecov Report

Merging #477 (363c909) into main (a518533) will increase coverage by 0.03%. The diff coverage is 97.50%.

:exclamation: Current head 363c909 differs from pull request most recent head 3e41060. Consider uploading reports for the commit 3e41060 to get more accurate results

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   79.09%   79.12%   +0.03%     
==========================================
  Files         128      128              
  Lines       10748    10822      +74     
==========================================
+ Hits         8501     8563      +62     
- Misses       1543     1549       +6     
- Partials      704      710       +6
Impacted Files Coverage Δ
internal/query/statement/select.go 95.21% <97.50%> (-4.79%) :arrow_down:
document/path.go 90.58% <0.00%> (-2.36%) :arrow_down:
internal/planner/optimizer.go 81.27% <0.00%> (-2.29%) :arrow_down:
internal/database/encoding.go 85.60% <0.00%> (-1.61%) :arrow_down:
internal/encoding/helpers.go 91.59% <0.00%> (+0.84%) :arrow_up:
internal/expr/comparison.go 87.50% <0.00%> (+1.92%) :arrow_up:
internal/expr/expr.go 71.79% <0.00%> (+2.56%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

asdine commented 11 months ago

Closing this as the codebase have changed quite a bit, and this is no longer neeed. Thanks @tzzed !