channel-io / bezier-react

React components library that implements Bezier design system.

https://main--62bead1508281287d3c94d25.chromatic.com

Apache License 2.0

231 stars 47 forks source link

Add the `basis` prop for flex-basis style to Layout components #2495

Closed sungik-choi closed 3 weeks ago

sungik-choi commented 3 weeks ago

Self Checklist

[x] I wrote a PR title in English and added an appropriate label to the PR.
[x] I wrote the commit message in English and to follow the Conventional Commits specification.
[x] I added the changeset about the changes that needed to be released. (or didn't have to)
[x] I wrote or updated documentation related to the changes. (or didn't have to)
[x] I wrote or updated tests related to the changes. (or didn't have to)
[x] I tested the changes in various browsers. (or didn't have to)
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Fixes #2457

Summary

레이아웃 컴포넌트에 basis prop 추가

Details

flex-basis 를 지원하는 basis prop을 추가합니다.
기존 grow, shrink 와 동일하게 flex- prefix를 제거하는 방식으로 네이밍했습니다.

Breaking change? (Yes/No)

References

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 560c90109b459add689891ea89cc77f8fcbc3676

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------ | ----- | | @channel.io/bezier-react | Minor | | bezier-figma-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

channeltalk[bot] commented 3 weeks ago

https://desk.channel.io/#/channels/1/team_chats/groups/1237/672dbd22086eb9d950a9

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.27%. Comparing base (ea1a6b1) to head (560c901). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2495 +/- ## ======================================= Coverage 82.27% 82.27% ======================================= Files 143 143 Lines 2979 2979 Branches 917 917 ======================================= Hits 2451 2451 + Misses 523 497 -26 - Partials 5 31 +26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

Chromatic Report

🚀 Congratulations! Your build was successful!