Open k----n opened 2 years ago
Sometimes the pull request or issue is referred to in a span tag e.g.:
"data" : {
"id" : "5723fd92e10a59c061074eed",
"text" : "Looks like those issues should be fixed with this bugfix: https://github.com/shoopio/shoop/pull/441",
"html" : """Looks like those issues should be fixed with this bugfix: <span data-link-type="issue" data-issue="441" data-issue-repo="shoopio/shoop" class="issue">shoopio/shoop#441</span>""",
"sent" : "2016-04-30T00:34:26.399Z",
"unread" : false,
"readBy" : 15,
"urls" : [ ],
"mentions" : [ ],
"issues" : [
{
"repo" : "shoopio/shoop",
"number" : "441"
}
],
Even when it's a pull request, it's linked as an "issue" in the span tag.
So github will need to be queried to classify as either pull request or issue
Here is some data that is gitter enriched for a pull request:
There should be
is_pull
according to here: https://github.com/chaoss/grimoirelab-elk/blob/b626512cd2768287bd1e52e98c7773073be21fc1/grimoire_elk/enriched/gitter.py#L166Maybe the regex isn't working? https://github.com/chaoss/grimoirelab-elk/blob/b626512cd2768287bd1e52e98c7773073be21fc1/grimoire_elk/enriched/gitter.py#L64
Here's a case with an issue:
There should be an
is_issue
key according to: https://github.com/chaoss/grimoirelab-elk/blob/b626512cd2768287bd1e52e98c7773073be21fc1/grimoire_elk/enriched/gitter.py#L163It's probably a regex issue again?