search

chapel-lang / pychapel

pych - The Python/Chapel integration module. NOTE: This repository is now deprecated.
Apache License 2.0
16 stars 13 forks source link

Fix trivial unit test error that started when numpy version changed #86

Closed awallace-cray closed 6 years ago

awallace-cray commented 6 years ago

The version of numpy brought in by pip changed, which changed some test outputs in meaningless ways (ie, spaces), and those meaningless changes broke a unit test with assertEquals( "string literal", test(something) )

This change fixes the unit test error, without at all addressing the underlying issue (hyper-sensitive string comparison).

awallace-cray commented 6 years ago

Forgot to mention - this change passes internally. Still fails on Travis.

lydia-duncan commented 6 years ago

Hmm, guess I was wrong that we had a way to force the version update. Unless we only applied it to a specific package? In any case, this change looks reasonable to me. Thanks, Tony!