chargebee / chargebee-typescript

Typescript library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=typescript
MIT License
23 stars 16 forks source link

Moved TS related packages to devDependencies #10

Closed harixth closed 3 years ago

harixth commented 3 years ago

What has Changed? Excluding typescript related packages to reduce down package size so that it does not get bloated.

Impacts The bundle size for this package should be significantly reduced when installing in other projects.

arminrosu commented 3 years ago

@cb-navaneedhan @cb-seenivasan can you folks merge this?

luads commented 3 years ago

This is very much needed. Your package is currently at 54mb. @cb-goutham any chance you can address it?

cb-rakesh commented 3 years ago

This has been merged in v2.2.0

arminrosu commented 3 years ago

@cb-rakesh you forgot to move "typescript": "^3.9.3" to devDeps as well. That's the biggest dependency. Issue still not resolved.

lohiaad commented 2 years ago

@cb-rakesh issue not closed yet. need to move "typescript": "^3.9.3" to devDependencies.

arminrosu commented 2 years ago

Now it seems to be fine. Finally. Thanks @cb-khushbubibay