charleskawczynski / PokerHandEvaluator.jl

A Poker hand evaluator, with Texas hold 'em in mind.

MIT License

6 stars 0 forks source link

Remove hand types, and just use symbols, to make core method type-stable #31

Closed charleskawczynski closed 3 years ago

charleskawczynski commented 3 years ago

I think, for progress sake, this seems like a good idea. Pros / cons:

Pro: the core method, evaluate5, is now type-stable, and can be type-stable all the way up the call graph
Con: this kind of limits us to the CPU because symbols are not isbits, but I think that's okay because this isn't technically needed to simulate games, it's only for printing.

Ultimately, the hand type is, at the moment, only needed for log/IO purposes, and the actual return integer is the key piece. If we wanted to still make this data available, we could return integers for the hand type and encode which hand type we have based on the second returned integer.

charleskawczynski commented 3 years ago

bors r+

codecov[bot] commented 3 years ago

Codecov Report

Merging #31 (74c0433) into main (a3a06cf) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         3    -1     
  Lines          154       180   +26     
=========================================
+ Hits           154       180   +26

Impacted Files	Coverage Δ
src/PokerHandEvaluator.jl	`100.00% <100.00%> (ø)`
src/evaluate5.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3a06cf...74c0433. Read the comment docs.

bors[bot] commented 3 years ago

Build failed:

docbuild

charleskawczynski commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: