charlielee / boats-animator

Stop motion animation program created using Electron
http://charlielee.uk/boats-animator
GNU General Public License v3.0
117 stars 17 forks source link

Add virtual numpad #246

Open le717 opened 5 years ago

le717 commented 5 years ago

Rioforce brought this up to me back when BA was just getting started, and I am finally getting around to filing it lol.

There should be a virtual number that maps to key actions, like capture, next/prev frame, etc, in the vein of the Dragonframe physical and virtual numpad. And naturally, if you support a virtual numpad, it'd be good to add physical numpad support too.

Luckily, I've already written it over in https://github.com/le717/numpad just for BA lol. It needs some updating, per API changes/best practices, but it's not much. It supports both physical and virtual clicks, and actions on both keyup and keydown events. I've even already written the HTML/CSS for the virtual numpad. Once I update the events, it'll still probably have to be updated more to integrate with BA, but it hopefully won't be hard (especially now with the module work you've done).

charlielee commented 5 years ago

Virtual numpad sounds fantastic! I really like the look of what you've done so far. ☺️

Physical numpads should already work with BA using the program's keyboard shortcuts. https://boatsanimator.readthedocs.io/en/latest/features/keyboard-shortcuts/