search

charlotte-ruby / image_scraper

simple utility that pulls image URLs from a web page
MIT License
21 stars 10 forks source link

Deprecation warnings #32

Closed invalidusrname closed 4 years ago

invalidusrname commented 4 years ago

Attempts to fix #21 

lib/image_scraper/client.rb:10: warning: URI.escape is obsolete
lib/image_scraper/client.rb:18: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open
invalidusrname commented 4 years ago

I've also added VCR to the test suite so we're not hitting the network everytime a test is ran. This also avoids errors that could happen when a url is not responsive.