search

charmaur / PolyDiceGenerator

A customizable Polyhedral Dice Generator for OpenSCAD.
https://github.com/charmaur/PolyDiceGenerator
Other
93 stars 20 forks source link

Update code to use BOSL2.0.669 #31

Closed arnoesterhuizen closed 10 months ago

arnoesterhuizen commented 11 months ago

I've updated the code to resolve

I did this as a learning exercise of SCAD, so please let me know if I borked up?

charmaur commented 11 months ago

Glad to see someone interested in making improvements!

I am, however, seeing a few issues while using the new BOSL2 version that will need further investigation.

Can you confirm if you're getting the same results?

  1. d4i has geometry issues.
  2. d4c is missing a '2'.
  3. d4, d8, d10, d00, d12, d12r, and d20 all have text rotation issues.

image

arnoesterhuizen commented 11 months ago

Ah, now that you point it out, I see what you mean. Let me have a look and see if I can tweak it some more, then update the pull request.

And thanks for this awesome generator; it is really helping me to dive into OpenSCAD!

arnoesterhuizen commented 11 months ago

I now see why the upgrade to the latest BOSL2 hasn't happened yet; this is a beast of an update. I'm going to have to chip away at this bit by bit, learning as I go.

charmaur commented 11 months ago

I haven't really worked on it in a few years. I do recall past updates messing up text rotation though. Let me know if you get stuck on something and I'll try to help.

arnoesterhuizen commented 10 months ago

Creating new pull request after a number of additional changes.