charmed-kubernetes / pytest-operator

Apache License 2.0
7 stars 13 forks source link

Keep all packed charms, if there are more than one #115

Closed sed-i closed 1 year ago

sed-i commented 1 year ago

When charmcraft.yaml has multiple bases, then multiple *.charm files are created. Before this PR, build_charm kept only one charm file:

find . -type f -name "*.charm"
./.tox/integration/tmp/pytest/test-juju-info-l4uc0/charms/grafana-agent_ubuntu-20.04-amd64.charm

With this PR we'd keep all *.charm files.

find . -type f -name "*.charm" 
./.tox/integration/tmp/pytest/test-juju-info-9fz20/charms/grafana-agent_ubuntu-20.04-amd64.charm
./.tox/integration/tmp/pytest/test-juju-info-9fz20/charms/grafana-agent_ubuntu-22.04-amd64.charm

Usage example:

sed-i commented 1 year ago

Could you please take a look @addyess @neoaggelos @carlcsaposs-canonical ?

addyess commented 1 year ago

@sed-i seems reasonable. If you can clean up the line issues i'd be okay to merge + release a new version.

sed-i commented 1 year ago

@addyess anything immediately obvious why itests fail?