search

charri / Font-Awesome-WPF

FontAwesome controls for WPF+UWP
MIT License
530 stars 147 forks source link

Strong name is required in many situations #14

Closed TrabacchinLuigi closed 8 years ago

TrabacchinLuigi commented 9 years ago

Strong name the assembly or it would not be usable in many situations

charri commented 9 years ago

this is definitely something I will look into.

TrabacchinLuigi commented 8 years ago

is there any way i can help with that ? Do you have some special requirement ? Like keeping secret the key while keeping everything open source ?

charri commented 8 years ago

Hi @TrabacchinLuigi, could you try this nuget package: https://www.nuget.org/packages/FontAwesome.WPF.Signed/

I opted in creating a seperate package, so developers can use either the signed or unsigned version.

What do you think?

TrabacchinLuigi commented 8 years ago

Sure i will! Monday!

TrabacchinLuigi commented 8 years ago

Good! Seems everything is working fine with the new version. I think that having two nuget packages is useless, can't see any advantage in using a non-signed version ... i would just go over the current package...

charri commented 8 years ago

this is something i would merge yes. just didn't want to f-up the "main" and stable version.

bzuillsmith commented 8 years ago

Could this be reopened until it's published in the regular package? A strong-named (signed) dll only allows references to other strong-named dlls so this is a pretty big issue. It would be helpful to be notified through this thread when you have this published in the main nuget package. For now, I'm also using the signed package

TrabacchinLuigi commented 8 years ago

Yes, would be nice to receive a notification so I'll reopen my solutions and change package

charri commented 8 years ago

will close once merged.

charri commented 8 years ago

As of 4.5.0.7 (commit 9382c418669df543f70cad61fa8b1a0212d99bd9) dlls will be signed.