search

cheahjs / bravefrontier_data

Holds extracted data for the game Brave Frontier (Global/JP/KR/EU)
63 stars 30 forks source link

Including Buff CODE ID for Leader skills? #22

Closed touchandswipe closed 9 years ago

touchandswipe commented 9 years ago

The new EU content has units (e.g. Skalmold) with ATK buff for Females and ATK buff for 5+ Elementals. The ATK buff are showing up as being similarly named, and not tied to the conditions. Would you be able to name it in similar ways with other ATK type buffs in BB / SBB skills? thank you

cheahjs commented 9 years ago

The (id) convention was used for buffs, not passives.

I might use [id] instead for passives.

touchandswipe commented 9 years ago

Wouldn't [ ] have problems with json? Maybe just a - would do? E.g. ATK Buff - 13 or ATK buff #17 On 20 Mar 2015 8:08 pm, "Cheah Jun Siang" notifications@github.com wrote:

The (id) convention was used for buffs, not passives.

I might use [id] instead for passives.

— Reply to this email directly or view it on GitHub https://github.com/Deathmax/bravefrontier_data/issues/22#issuecomment-83960311 .

cheahjs commented 9 years ago

AFAIK, [] doesn't need to be escaped. In any case, I'll be exposing the underlying ids for the effects in the next push.

touchandswipe commented 9 years ago

True that but [ ] is being read as an array type. Thanks and would be nice On 20 Mar 2015 8:21 pm, "Cheah Jun Siang" notifications@github.com wrote:

AFAIK, [] doesn't need to be escaped. In any case, I'll be exposing the underlying ids for the effects in the next push.

— Reply to this email directly or view it on GitHub https://github.com/Deathmax/bravefrontier_data/issues/22#issuecomment-83963875 .