search

checkupjs / checkup

A health checkup for your project.
https://checkupjs.github.io/
MIT License
76 stars 23 forks source link

ember-es6-class/no-object-extend rule #447

Open hmajoros opened 4 years ago

hmajoros commented 4 years ago

https://github.com/checkupjs/checkup/blob/8f88c8ba8bdc03bdb417fec1bfbcaff9de0ac5de/packages/checkup-plugin-ember-octane/src/utils/task-configs.ts#L12

any reason this chunk isn't using the no-object-extend rule defined here? https://github.com/scalvert/eslint-plugin-ember-es6-class

this is what our team used to track our native class migration

scalvert commented 4 years ago

Hey @hmajoros, thanks for the issue, and this is a good question.

There's no real reason - we could likely add it to the rest of the rules to ensure we're covering all our bases.

Thanks for the suggestion!

lbdm44 commented 3 years ago

@scalvert is there a reason we should be using no-extend-object over the combo of the standard Ember ember/no-classic-classes and ember/no-mixins? Seems like the combination of the two cover the enforcement of ES6 Classes and removing .extend which is only used for mixins at this point.

The only possible corner case I can see is that engineers are using ES6 classes with .extend outside of mixins, but that seems irresponsible considering they should just be using ES6 class extension.