chef-boneyard / chef-provisioning-vsphere

DEPRECATED: A chef-provisioning provisioner for VMware vSphere
MIT License
17 stars 15 forks source link

Ready timeout fix #71

Closed tuccimon closed 6 years ago

tuccimon commented 6 years ago

Description

According to the documentation, the .kitchen.yml file contains the :ready_timeout parameter under machine_options directly - not bootstrap_options. Because bootstrap_options is passed to the ip_to_bootstrap function, :ready_timeout is not visible.

      # TODO: please create a better solution for the below
      # bootstrap_options shouldn't contain the :ready_timeout value - machine_options does
      # however, I don't want to break previous work or change all the calls made to this function
      # setting a default, as for most people bootstrap_options[:ready_timeout] will be nil
      # another possible workaround is to add a second entry under bootstrap_options in .kitchen.yml

Issues Resolved

The commit https://github.com/chef-partners/chef-provisioning-vsphere/commit/0040fb83809f7ed2d0723c1dc4020f984e8c450a essentially broke mine (and I'm guessing others who are following the doc's standard for the .kitchen.yml file). Added an OR comparison to essentially assign the value of 90 in case bootoptions[:ready_timeout] resolves to nil so as to no longer break.

Check List

tuccimon commented 6 years ago

Sorry for the confusion with the multiple commits. Kept getting "class has too many lines" errors in Travis CI. I condensed the change into one line.

jjasghar commented 6 years ago

Can you squash this down to one commit, it looks good to ship.

tuccimon commented 6 years ago

Closing this pull request. Will submit another.