chef-boneyard / delivery-sugar

DEPRECATED: Library cookbook that adds sugar to build cookbooks for Chef Delivery
Apache License 2.0
12 stars 26 forks source link

COOL-613: Add categories property to the supermarket upload method. #11

Closed TheLunaticScripter closed 8 years ago

TheLunaticScripter commented 8 years ago

When running Automate 0.5.1 with ChefDK 0.16.28 on a disconnected network I had an issue where when publishing a cookbook to the private supermarket publish would attempt to go the public supermarket unless a category was specified. This pull request fixes this issue by adding a property for categories to that library. This problem appears also be fixed by upgrading to ChefDK 0.18.30. In order to fully utilize this property I believe the delivery-truck cookbook will also need to be updated.

cwebberOps commented 8 years ago

@TheLunaticScripter I could have sworn I poked someone internally on this. Let me go see what I can do.

TheLunaticScripter commented 8 years ago

@cwebberOps Thanks no worries :)

afiune commented 8 years ago

@TheLunaticScripter I just have one tiny comment above... When you fix that I'll push this change through our pipeline! 🎉

afiune commented 8 years ago

@TheLunaticScripter Oops, you forgot to "Sign-off" the commit. You can just amend them on a single commit. 😄

Probably some tests would be good but if not, I'll add them for you. Thanks!

afiune commented 8 years ago

Way to go @TheLunaticScripter !!! Thanks for fixing this ... I'm pushing your PR through our internal Automate Workflow server right away.. 👍 🎉

afiune commented 8 years ago

Looking good! 😸 It is under review..

screen shot 2016-11-10 at 11 14 54 am

TheLunaticScripter commented 8 years ago

@afiune Awesome!!! Thank you again for all the help. 😀

afiune commented 8 years ago

Change was approved and merged!!

Closing this in favor of: https://github.com/chef-cookbooks/delivery-sugar/commit/605bbb2fa12a7931131fc30c8d9b8aa489b977be

Thank you @TheLunaticScripter for your contribution .. Great work! 👏