ssh-keyscan shell call causes chef-client worker to hang

chef-cookbooks / ssh_known_hosts

Development repository for Chef Cookbook ssh_known_hosts

https://supermarket.chef.io/cookbooks/ssh_known_hosts

Apache License 2.0

72 stars 77 forks source link

ssh-keyscan shell call causes chef-client worker to hang #47

Closed kbruner closed 8 years ago

kbruner commented 8 years ago

We had a problem with chef-client workers hanging indefinitely, which I narrowed down to the ssh-keyscan run in a ssh_known_hosts_entry 'github.com' resource. There seem to be cases where it will connect and never close/timeout, which means chef-client won't complete. Any reason not to run ssh-keyscan with mixlib/shellout with its timeout?

iennae commented 8 years ago

@kbruner Thanks for this report. I've added shell_out with a timeout as of v 3.0.1 of the cookbook. Hopefully this resolves this issue for you. If not, please do reopen! Thanks!