Handle nonstandard ssh port

benweissmann commented 8 years ago

Description

Handle non-standard SSH ports in the known_hosts file.

This PR does not include tests. It looks like the existing testing infrastructure for this cookbook doesn't have a great way to add a test for handling non-standard SSH ports. Suggestions for how to design a test for this change would be much appreciated.

This PR also adds an explicit require 'English'. I was seeing an error where the /etc/ssh/ssh_known_hosts file had no newlines in it after a chef run because $INPUT_RECORD_SEPARATOR was nil.

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

volker-fr commented 8 years ago

Are there any plans to merge this?

lamont-granquist commented 8 years ago

replaced by #63

chef-cookbooks / ssh_known_hosts

Handle nonstandard ssh port #53

Description

Check List